-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Delay" column to Query Log #2757
Conversation
Signed-off-by: DL6ER <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe 'Delay' is not the best phrase to use. Users could think Pi-hole is delaying query resolution and will start to ask how to reduce delay. Maybe 'Reply time' or simply 'time' or 'query time' would be better
I have been thinking about the name, too.
|
'Type' could give some space to be used in 'Query time' |
Maybe Or
|
Actually I don't know how to steal width from type. It is not intentionally that big. @yubiuser Do you remember when you asked why I added all the additional sorting possibilities we aren't using right now in FTL? We just found the one that was missing: pi-hole/FTL#1671 |
Signed-off-by: DL6ER <[email protected]>
60bd0eb
to
c1d0523
Compare
This is coming from here: Lines 88 to 90 in 3dd5752
The third column was Domain column in v5, but the CSS was never updated. We can also fix/remove line 84. |
Signed-off-by: DL6ER <[email protected]>
Review comments addressed, I like the idea of going forward with an icon having a hover text for the curious and fixed the CSS to get rid of the wide type column. |
What does this implement/fix?
Discourse Feature request: Add "Delay" column to Query Log (as it was with v5)
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.