Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Delay" column to Query Log #2757

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Add "Delay" column to Query Log #2757

merged 3 commits into from
Oct 26, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 16, 2023

What does this implement/fix?

Discourse Feature request: Add "Delay" column to Query Log (as it was with v5)

Screenshot from 2023-10-16 16-48-01

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 'Delay' is not the best phrase to use. Users could think Pi-hole is delaying query resolution and will start to ask how to reduce delay. Maybe 'Reply time' or simply 'time' or 'query time' would be better

scripts/pi-hole/js/queries.js Show resolved Hide resolved
scripts/pi-hole/js/queries.js Outdated Show resolved Hide resolved
@DL6ER
Copy link
Member Author

DL6ER commented Oct 16, 2023

I have been thinking about the name, too.

  • Time is already used on the very left - even if we'd change it is "timestamp", "time" still doesn't fit in here IMO
  • any combination ("reply time", "query time", etc.) will break the line and make the header double in height. This looked very ugly in my tests.

@yubiuser
Copy link
Member

any combination ("reply time", "query time", etc.) will break the line and make the header double in height. This looked very ugly in my tests.

'Type' could give some space to be used in 'Query time'

@rdwebdesign
Copy link
Member

rdwebdesign commented Oct 16, 2023

Maybe R. Time?

Or

<th title="Reply Time">Time</th>

@DL6ER
Copy link
Member Author

DL6ER commented Oct 16, 2023

Actually I don't know how to steal width from type. It is not intentionally that big.

@yubiuser Do you remember when you asked why I added all the additional sorting possibilities we aren't using right now in FTL? We just found the one that was missing: pi-hole/FTL#1671

@rdwebdesign
Copy link
Member

rdwebdesign commented Oct 16, 2023

I don't know how to steal width from type. It is not intentionally that big.

This is coming from here:

web/style/pi-hole.css

Lines 88 to 90 in 3dd5752

/* Domain column */
#all-queries td:nth-of-type(3) {
min-width: 200px;

The third column was Domain column in v5, but the CSS was never updated. We can also fix/remove line 84.

@rdwebdesign
Copy link
Member

About the "Delay" name:
If you want to change the column name, but also use less space maybe we could use an icon:

image

@DL6ER
Copy link
Member Author

DL6ER commented Oct 24, 2023

Review comments addressed, I like the idea of going forward with an icon having a hover text for the curious and fixed the CSS to get rid of the wide type column.

@DL6ER DL6ER merged commit f516e04 into development-v6 Oct 26, 2023
7 checks passed
@DL6ER DL6ER deleted the tweak/query_log_delay branch October 26, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants