Finalize renaming adlists -> lists

[DL6ER]

What does this implement/fix?

Finish the only partially done renaming adlists -> lists on the dashboard. This fixes a few broken links such as "Manage lists" on the dashboard as well as the generated links from the Search Lists page to the Groups -> Lists page with enabled list row highlighting

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)

Checklist:

• The code change is tested and works locally.
• I based my code and PRs against the repositories developmental branch.
• I signed off all commits. Pi-hole enforces the DCO for all contributions
• I signed all my commits. Pi-hole requires signatures to verify authorship
• I have read the above and my PR is ready for review.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved.

[yubiuser]

I'm not so happy with that change. I know gravity can now contain also allowlists (anti-gravity) and adlists is not the best term anymore. However, a generic 'list' makes it impossible to distinguish gravity from manually managed allow/deny lists.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved.

[DL6ER]

Github says:

yet on the CLI:

$ git merge development-v6 

Auto-merging scripts/pi-hole/js/groups-lists.js
Merge made by the 'ort' strategy.
 scripts/pi-hole/js/gravity.js      | 3 +--
 scripts/pi-hole/js/groups-lists.js | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

🤔 🤷‍♂️

[PromoFaux]

However, a generic 'list' makes it impossible to distinguish gravity from manually managed allow/deny lists.

Would you mind expanding on this a little? Do you have an alternative suggestion?

[DL6ER]

Maybe along the lines of subscriptions or subscribed lists but they are pretty long phrases. Or we go German and say Abos (which means subscriptions)

[yubiuser]

In the end it comes down to the difference between subscibed lists and self-curated lists (and a few different supported syntax on the lists). I think subscriptions is a nice term - it can be both "adlist" and "anti-adlists" now. And domainlist can stay as it is

[DL6ER]

This is just too long to be good...

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[PromoFaux]

Coming back to this... I think lists is an adequate descriptor for this, and to be honest I'm failing to see where the confusion would lie. Subscriptions is a change of terminology all together, and would possibly cause even more confusion...

[github-actions]

Conflicts have been resolved.

[NittanySeaLion]

In groups-lists.lp, line 65, consider changing "List of subscribed lists" to "Subscribed lists"