Insert icheck CSS right after bootstrap file. #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RD WebDesign <[email protected]>
These CSS rules apply some changes to icheck items in Domains page, but these changes are not desired on both lcars themes. The previous code excluded only the original LCARS theme from this rule. This change will allow the same behavior on both themes. Signed-off-by: RD WebDesign <[email protected]>
rdwebdesign
force-pushed
the
icheck_css_order
branch
from
5612389 to
099f2bc
Compare
yubiuser
approved these changes
Oct 16, 2023
DL6ER
approved these changes
Oct 16, 2023
Merged
truecharts-admin
referenced
this pull request
in truecharts/public
Nov 24, 2023
…f8 (#15274) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pihole/pihole](https://togithub.com/pi-hole/docker-pi-hole) | minor | `2023.10.0` -> `2023.11.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (pihole/pihole)</summary> ### [`v2023.11.0`](https://togithub.com/pi-hole/docker-pi-hole/releases/tag/2023.11.0) [Compare Source](https://togithub.com/pi-hole/docker-pi-hole/compare/2023.10.0...2023.11.0) Nothing Docker specific, this release pulls in web v5.21 https://github.com/pi-hole/web/releases/tag/v5.21 <!-- Release notes generated using configuration in .github/release.yml at devel --> #### What's Changed - Insert icheck CSS right after bootstrap file. by [@​rdwebdesign](https://togithub.com/rdwebdesign) in [https://github.com/pi-hole/web/pull/2752](https://togithub.com/pi-hole/web/pull/2752) - New (additional) LCARS theme inspired by Picard TV show by [@​MichalSvatos](https://togithub.com/MichalSvatos) in [https://github.com/pi-hole/web/pull/2709](https://togithub.com/pi-hole/web/pull/2709) - Add word break for clients column to avoid horizontal scrollbar by [@​rdwebdesign](https://togithub.com/rdwebdesign) in [https://github.com/pi-hole/web/pull/2838](https://togithub.com/pi-hole/web/pull/2838) #### New Contributors - [@​MichalSvatos](https://togithub.com/MichalSvatos) made their first contribution in [https://github.com/pi-hole/web/pull/2709](https://togithub.com/pi-hole/web/pull/2709) **Full Changelog**: pi-hole/web@v5.20.2...v5.21 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy42NS4wIiwidXBkYXRlZEluVmVyIjoiMzcuNjUuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does this PR aim to fix?
Note: this PR is aimed to fix issues identified during the tests of the new LCARS Picard theme.
In CSS, the order of files matters.
The current code inserts
icheckCSS in the end of<HEAD>tag (after all theme files).icheckCSS file uses a few!importantrules.If a theme needs to change something related to
icheckelements, a higher selector specificity is needed (in addition to!importantrules).Another issue is the use of
body:not(.lcars). This selector doesn't work for the new theme, but it should.How does this PR fix the issues?
Changing where we insert this CSS file.
Replacing the
body:not(.lcars)selector withbody:not([class*="lcars"]).These changes will reduce the need of complex selectors or hacks to achieve a higher specificity.
Link documentation PRs if any are needed to support this PR:
none
By submitting this pull request, I confirm the following:
git rebase)