Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate 404 Error Page Based on @DL6ER #2749

Closed
wants to merge 12 commits into from
Closed

Alternate 404 Error Page Based on @DL6ER #2749

wants to merge 12 commits into from

Conversation

NittanySeaLion
Copy link

@NittanySeaLion NittanySeaLion commented Oct 15, 2023

404 Error Page with commented out redirect

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

Looks different: image

Adds a comment to allow automatic redirects and makes hyperlink specific for IP addresses.

(Not sure if easier/proper to do an alternate pull request. Feel free to close if not.)


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

yubiuser and others added 10 commits October 14, 2023 15:27
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
404 Error Page with commented out redirect

Signed-off-by: NittanySeaLion <[email protected]>
@NittanySeaLion
Copy link
Author

I've also added a commit that fixes a broken web link in DNS settings. According to https://wander.science/projects/dns/dnssec-resolver-test/ "This test was created in May 2012 to measure the adoption of DNSSEC validation in the web. It was running on dnssec.vs.uni-due.de until the University suffered from a ransomware attack in November 2022. In March 2023, it was relaunched on wander.science. Currently, it does not collect any data."

@NittanySeaLion
Copy link
Author

I wanted to also fix the adlist link per https://discourse.pi-hole.net/t/urls-on-dashboard-give-a-404/65631?u=blockhead

Not sure where those other commits from others came from

@NittanySeaLion
Copy link
Author

Decided to leave it as a customization option, if a user desires.

https://discourse.pi-hole.net/t/error-page-404-etc/65715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants