Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404 error page #2746

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Add 404 error page #2746

merged 3 commits into from
Nov 1, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 14, 2023

What does this implement/fix?

Add explicit 404 error page to be shown for non-existing pages:

Screenshot from 2023-10-14 16-02-45

You can test this page by manually browsing to http://pi.hole/admin/error404 or by using FTL from PR pi-hole/FTL#1664 where it will automatically be used as 404 page for any non-available pages.

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <[email protected]>
error404.lp Outdated Show resolved Hide resolved
error404.lp Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved.

@DL6ER DL6ER requested review from rdwebdesign and yubiuser October 29, 2023 20:01
@DL6ER DL6ER enabled auto-merge November 1, 2023 17:22
@DL6ER DL6ER dismissed yubiuser’s stale review November 1, 2023 17:22

Comment has been addressed

@DL6ER DL6ER merged commit 92be8b6 into development-v6 Nov 1, 2023
7 checks passed
@DL6ER DL6ER deleted the new/error_pages branch November 1, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants