Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify theme handling #2718

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Simplify theme handling #2718

merged 1 commit into from
Sep 29, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Sep 26, 2023

What does this implement/fix?

Remove theme.lua, source everything there is to know about the themes through Lua instead - pihole.webtheme() does now return a full table having all the details.

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…ead (pihole.webtheme() now returns a full table)

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER requested review from rdwebdesign and a team September 26, 2023 08:19
@DL6ER DL6ER merged commit 6bf3d09 into development-v6 Sep 29, 2023
6 checks passed
@DL6ER DL6ER deleted the tweak/themes branch September 29, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants