Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid caching issues using last modified time #2489

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Previous code was using a similar technique, but it was using the same value (last update time of /admin/scripts/pi-hole/php/header.php ) for every file.

How does this PR accomplish the above?

A new function was created to verify the last update time of each file.

Link documentation PRs if any are needed to support this PR:**

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign rdwebdesign requested a review from a team January 13, 2023 21:06
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not working for the *.css files included in the style of

<link rel="<?php echo fileversion('stylesheet" href="style/vendor/bootstrap-toggle.min.css'); ?>">

but working for inclusions like <link rel="stylesheet" href="<?php echo fileversion('style/pi-hole.css'); ?>">

@rdwebdesign
Copy link
Member Author

Yeah... because I made a Copy/Paste mistake.
Fixed.

@rdwebdesign rdwebdesign merged commit 9006c41 into devel Jan 14, 2023
@rdwebdesign rdwebdesign deleted the fix/cachever branch January 14, 2023 02:14
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-20-1-web-v5-18-1-and-core-v5-15-released/60495/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants