Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glow effect in "Total Queries" box result in blurry text. #3011

Closed
rdwebdesign opened this issue Apr 20, 2024 · 5 comments · Fixed by #3032
Closed

Glow effect in "Total Queries" box result in blurry text. #3011

rdwebdesign opened this issue Apr 20, 2024 · 5 comments · Fixed by #3032

Comments

@rdwebdesign
Copy link
Member

The glow effect (used when the Total Queries value is updated) creates a blurry effect, specially in dark themes.

glow

This is not very user friendly for users with some kind of visual impairment or anything different than a perfect vision (and almost nobody has perfect vision).

Suggestions:

  1. Remove the effect from "High Contrast" and "High Contrast Dark" themes;
  2. Change the color effect to some dark color;
  3. Replace this effect by some other effect;
  4. Remove the effect from every theme;
  5. other options?

The issue affects all themes (v5 and v6).

This was reported by an user, on Discourse:
https://discourse.pi-hole.net/t/fuzzy-changes-to-total-queries/69695

@PromoFaux
Copy link
Member

Following the KISS principle...

Remove the effect from every theme;

I would vote this one. It doesn't really add an awful lot

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@github-actions github-actions bot added the stale label May 22, 2024
rdwebdesign added a commit that referenced this issue May 23, 2024
to avoid accessibility issues

Fixes #3011

Signed-off-by: RD WebDesign <[email protected]>
@rdwebdesign
Copy link
Member Author

Just to make sure that removing the effect is our best option, I tested using a different effect (changing the color of the text), but it doesn't look good if I use a color that is too contrasting to the original.

This is the result using "White to Black to White":
white to black

It looks very disturbing, specially considering accessibility.

I will completely remove the glow effect.

@github-actions github-actions bot removed the stale label May 23, 2024
rdwebdesign added a commit that referenced this issue May 23, 2024
to avoid accessibility issues

Fixes #3011

Signed-off-by: RD WebDesign <[email protected]>
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@github-actions github-actions bot added the stale label Jun 23, 2024
@rdwebdesign
Copy link
Member Author

Fixed in v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants