-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify domains, lists, clients and group names as arrays #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Do we need to merge development-v6 here? |
…ist addresses at once Signed-off-by: DL6ER <[email protected]>
DL6ER
force-pushed
the
tweak/domain_array
branch
from
October 7, 2023 19:38
48f27ef
to
a6ba2a8
Compare
I just did it - it never hurts and we should pull in the theme changes. |
Yeah... the theme was broken. Thanks. |
…ups, lists and clients Signed-off-by: DL6ER <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. |
Signed-off-by: DL6ER <[email protected]>
DL6ER
force-pushed
the
tweak/domain_array
branch
from
October 14, 2023 14:23
ca29eef
to
4020177
Compare
rdwebdesign
requested changes
Oct 22, 2023
Signed-off-by: DL6ER <[email protected]>
Review comments addressed |
rdwebdesign
approved these changes
Oct 24, 2023
This was referenced Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This PR accompanies the related FTL PR pi-hole/FTL#1629. It depends on #2700 which should be merged first to ease the reviewing process.
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.