-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify domains, lists, clients and group names as arrays #1629
Conversation
Changing this to "ready for review" and kindly asking for the same |
This branch continues to work with the current edit See also the related PR pi-hole/web#2707. |
…o Pi-hole's lists Signed-off-by: DL6ER <[email protected]>
…ays for creating multiple with the same properties (comment, groups, ...) at the same time Signed-off-by: Dominik Derigs <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
…ted it (not if we are merely using a copy) Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
a755396
to
1161463
Compare
Rebased on latest |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: DL6ER <[email protected]>
Conflicts have been resolved. |
…any items have been successfully added, how many have failed and, if, what the individual errors were Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. |
Signed-off-by: DL6ER <[email protected]>
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/adding-batch-adlists/65446/3 |
This PR has recently been affected by a bug solved in #1659 and should be reviewed thereafter. |
This PR is now ready. |
What's the reason to accept |
Following the REST principles, you should add/manipulate one entry per call so sending a string feels natural here. We simply extend this natural feeling by also allowing arrays. You are right, an array of size 1 is exactly identical to a naked string, however, to my understanding, rejecting plain strings and demanding them to be encapsulated in an otherwise empty array shell feels odd to me. |
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/add-client-or-group-in-management-doesnt-work/65855/5 |
What does this implement/fix?
Add ability to specify domains, lists, clients and group names as arrays
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.