Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools > Search adlists has not obvious default behaviour when pressing Enter inside textbox #2701

Closed
tobbi opened this issue Sep 4, 2023 · 11 comments · Fixed by #2957
Closed

Comments

@tobbi
Copy link

tobbi commented Sep 4, 2023

Versions

Platform

  • OS and version: Debian 11
  • Platform: Raspberry Pi

Expected behavior

The button for the action that gets executed when pressing Enter in the Search Adlists text field is highlighted.

Actual behavior / bug

When pressing Enter inside the "Domain to look for (example.com or sub.example.com)", it is not clear whether "Search partial match" or "Search exact match" is triggered. From the behaviour, it looks like it's "Search partial match", but this is not clear to the user.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to Tools > Search adlists.
  2. Click inside the "Domain to look for (example.com or sub.example.com)" textbox and enter a search term.
  3. Press Enter
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@github-actions github-actions bot added the stale label Oct 5, 2023
@tobbi

This comment was marked as spam.

@yubiuser
Copy link
Member

yubiuser commented Oct 5, 2023

You're correct this is a UI bug.

Copy link
Contributor

github-actions bot commented Nov 5, 2023

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@github-actions github-actions bot added the stale label Nov 5, 2023
@yubiuser yubiuser removed the stale label Nov 5, 2023
Copy link
Contributor

github-actions bot commented Dec 6, 2023

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@github-actions github-actions bot added the stale label Dec 6, 2023
@yubiuser yubiuser removed the stale label Dec 6, 2023
Copy link
Contributor

github-actions bot commented Jan 6, 2024

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@github-actions github-actions bot added the stale label Jan 6, 2024
@yubiuser yubiuser removed the stale label Jan 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@github-actions github-actions bot added the stale label Feb 6, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
@tobbi
Copy link
Author

tobbi commented Feb 12, 2024

Can this please be reopened?

@github-actions github-actions bot removed the stale label Feb 12, 2024
@yubiuser yubiuser reopened this Feb 12, 2024
@tobbi
Copy link
Author

tobbi commented Feb 12, 2024

Is there a way to prevent the bot from marking this as "stale"?

DL6ER added a commit that referenced this issue Feb 12, 2024
DL6ER added a commit that referenced this issue Feb 12, 2024
@DL6ER
Copy link
Member

DL6ER commented Feb 12, 2024

We could either put the never-stale label on it or fix the underlying issue itself :-)

I propose the latter: #2957

@DL6ER DL6ER linked a pull request Feb 12, 2024 that will close this issue
5 tasks
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@github-actions github-actions bot added the stale label Mar 14, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants