avoid "Undefined variable $unicode" warnings

In the original form I was getting warnings like ``` <b>Warning</b>: Undefined variable $unicode in <b>/var/www/html/admin/scripts/pi-hole/php/func.php</b> on line <b>687</b><br /> ``` printed in the HTML output of `/scripts/pi-hole/php/groups.php`, which was not a valid JSON any more and led to an error displaying the blacklisted domains. Signed-off-by: Costin Grigoras <[email protected]>
pi-hole · Jan 2, 2025 · b525cd3 · b525cd3
1 parent 5c8945c
commit b525cd3
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/scripts/pi-hole/php/func.php b/scripts/pi-hole/php/func.php
@@ -684,7 +684,7 @@ function convertIDNAToUnicode($IDNA)
     }
 
     // if the conversion failed (e.g. domain to long) return the original domain
-    if ($unicode == false) {
+    if (!isset($unicode) || $unicode == false) {
         return $IDNA;
     } else {
         return $unicode;