Settings pages: move level selector from top bar and add page titles

Signed-off-by: RD WebDesign <[email protected]>
pi-hole · Jul 19, 2023 · b26dcf3 · b26dcf3
1 parent 7c00023
commit b26dcf3
Show file tree

Hide file tree

Showing 10 changed files with 39 additions and 8 deletions.
diff --git a/scripts/pi-hole/lua/header_authenticated.lp b/scripts/pi-hole/lua/header_authenticated.lp
@@ -50,14 +50,6 @@ mg.include('header.lp','r')
             </a>
             <div class="navbar-custom-menu">
                 <ul class="nav navbar-nav">
-                <? if startsWith(scriptname, 'settings/') then ?>
-                    <li class="nav-item">
-                        <p class="navbar-text">
-                            Settings level: <select id="settings-level" class="form-control input-sm">
-                            </select>
-                        </p>
-                    </li>
-                <? end ?>
                     <li<? if string.len(hostname) == 0 then ?> class="hidden"<? end ?>>
                         <p class="navbar-text">
                             <span class="hidden-xs">hostname:</span>

diff --git a/scripts/pi-hole/lua/settings_header.lp b/scripts/pi-hole/lua/settings_header.lp
@@ -0,0 +1,7 @@
+<!-- Title -->
+<div class="page-header flex-header">
+    <h1><?= PageTitle ?></h1>
+    <div class="settings-selector">
+        Settings level: <select id="settings-level" class="form-control input-sm"></select>
+    </div>
+</div>
diff --git a/settings-advanced.lp b/settings-advanced.lp
@@ -8,6 +8,10 @@
 --]]
 
 mg.include('scripts/pi-hole/lua/header_authenticated.lp','r')
+
+-- Page title and level selector
+PageTitle = "Advanced Settings"
+mg.include('scripts/pi-hole/lua/settings_header.lp','r')
 ?>
 <div class="row settings-level-2" id="advanced-content">
     <!-- dynamically filled with content -->

diff --git a/settings-api.lp b/settings-api.lp
@@ -8,6 +8,10 @@
 --]]
 
 mg.include('scripts/pi-hole/lua/header_authenticated.lp','r')
+
+-- Page title and level selector
+PageTitle = "Web Interface - API Settings"
+mg.include('scripts/pi-hole/lua/settings_header.lp','r')
 ?>
 <div class="row">
     <div class="col-md-6 settings-level-1">

diff --git a/settings-dhcp.lp b/settings-dhcp.lp
@@ -8,6 +8,10 @@
 --]]
 
 mg.include('scripts/pi-hole/lua/header_authenticated.lp','r')
+
+-- Page title and level selector
+PageTitle = "DHCP Settings"
+mg.include('scripts/pi-hole/lua/settings_header.lp','r')
 ?>
 <div class="row">
     <!-- DHCP Settings Box -->

diff --git a/settings-dns.lp b/settings-dns.lp
@@ -8,6 +8,10 @@
 --]]
 
 mg.include('scripts/pi-hole/lua/header_authenticated.lp','r')
+
+-- Page title and level selector
+PageTitle = "DNS Settings"
+mg.include('scripts/pi-hole/lua/settings_header.lp','r')
 ?>
 <div class="row">
     <div class="col-lg-6">

diff --git a/settings-dnsrecords.lp b/settings-dnsrecords.lp
@@ -8,6 +8,10 @@
 --]]
 
 mg.include('scripts/pi-hole/lua/header_authenticated.lp','r')
+
+-- Page title and level selector
+PageTitle = "Local DNS Settings"
+mg.include('scripts/pi-hole/lua/settings_header.lp','r')
 ?>
 <div class="row">
     <div class="col-md-6 settings-level-1">

diff --git a/settings-privacy.lp b/settings-privacy.lp
@@ -8,6 +8,10 @@
 --]]
 
 mg.include('scripts/pi-hole/lua/header_authenticated.lp','r')
+
+-- Page title and level selector
+PageTitle = "Privacy Settings"
+mg.include('scripts/pi-hole/lua/settings_header.lp','r')
 ?>
 <div class="row">
     <div class="col-md-6 settings-level-0">

diff --git a/settings-system.lp b/settings-system.lp
@@ -8,6 +8,10 @@
 --]]
 
 mg.include('scripts/pi-hole/lua/header_authenticated.lp','r')
+
+-- Page title and level selector
+PageTitle = "System Settings"
+mg.include('scripts/pi-hole/lua/settings_header.lp','r')
 ?>
 <div class="row">
     <div class="col-md-6">

diff --git a/settings-teleporter.lp b/settings-teleporter.lp
@@ -8,6 +8,10 @@
 --]]
 
 mg.include('scripts/pi-hole/lua/header_authenticated.lp','r')
+
+-- Page title and level selector
+PageTitle = "Teleporter"
+mg.include('scripts/pi-hole/lua/settings_header.lp','r')
 ?>
 <div class="row">
     <div class="col-md-6">