Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom wildcard DNS records. #5591

Closed
wants to merge 3 commits into from

Conversation

DjoSmer
Copy link

@DjoSmer DjoSmer commented Feb 27, 2024

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Wildcard DNS, for those who don’t know – is a trick to allow any kind of host name – to have a specific same IP as it’s DNS name. For example, if my domain is test.com and my IP is 1.2.3.4, the record full.test.com will also have the same IP: 1.2.3.4.

WildcardDNS.mov

How does this PR accomplish the above?:

I wrote 3 new admin commands which do this.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux
Copy link
Member

Thank you for the submission, however unfortunately we are no longer accepting new features for version 5 of Pi-hole.

I could potentially see this being acceptable as an idea (not nessacerily this implementation) in v6 - but It should be discussed first with @DL6ER, he may have some opinions on why this is not currently a feature...

Closing for now, but thanks again for the submission!

@PromoFaux PromoFaux closed this May 8, 2024
@DL6ER
Copy link
Member

DL6ER commented May 10, 2024

This is already available via regex blocking which is a much more powerful tool when it comes to wildcard matching. You can easily reconstruct your example using something like

(^|\.)test\.com;reply=1.2.3.4

to get the behavior you are describing above. I don't think it's a wise idea to add "the same thing" twice in a different form as this makes it hard for users to decide when they should use one or the other.

@DjoSmer
Copy link
Author

DjoSmer commented Jul 6, 2024

This is already available via regex blocking which is a much more powerful tool when it comes to wildcard matching. You can easily reconstruct your example using something like

(^|\.)test\.com;reply=1.2.3.4

to get the behavior you are describing above. I don't think it's a wise idea to add "the same thing" twice in a different form as this makes it hard for users to decide when they should use one or the other.

You said this is already available, I agree. It is already exists in dnsmasq. PI-hole has used dnsmasq, I just add some commands in Pi-hole's script.
If this feature exists in dnsmasq, why it can't be used and your solution is not clear.

I really I don't understand this patch has some changes and you didn't get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants