Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PID file instead of pidof output for gdb debugging #1058

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Jun 11, 2024

What does this PR aim to accomplish?:

Improve the debugging command.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from DL6ER June 11, 2024 19:47
Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit c06dbe0
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/6669cb9e86421b000870963b
😎 Deploy Preview https://deploy-preview-1058--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yubiuser yubiuser enabled auto-merge June 12, 2024 16:23
@yubiuser yubiuser merged commit e5b49cc into master Jun 12, 2024
9 of 10 checks passed
@yubiuser yubiuser deleted the gdb branch June 12, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants