-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some hardening to the build script #1644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And from my synology, which does not have buildx...
And back to the main machine to prove it still works:
|
PromoFaux
force-pushed
the
sanity-check-downloaded-FTL
branch
2 times, most recently
from
September 11, 2024 21:52
c710042
to
1b0c41d
Compare
rdwebdesign
reviewed
Sep 11, 2024
yubiuser
requested changes
Sep 12, 2024
rdwebdesign
requested changes
Sep 12, 2024
PromoFaux
force-pushed
the
sanity-check-downloaded-FTL
branch
from
September 13, 2024 16:54
1b0c41d
to
a200625
Compare
PromoFaux
force-pushed
the
sanity-check-downloaded-FTL
branch
from
September 13, 2024 17:43
a200625
to
5631794
Compare
…ildx installed. When using custom branches, check they actuall exist before proceeding with the build Signed-off-by: Adam Warner <[email protected]>
yubiuser
approved these changes
Sep 13, 2024
rdwebdesign
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Drawing inspiration from: #1643 (comment)
And also from a comment where a user mentioned they could not run the build script due to missing buildx on their system. (I cannot find the comment...)
By submitting this pull request, I confirm the following:
git rebase
)What does this PR aim to accomplish?:
By submitting this pull request, I confirm the following:
git rebase
)