Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default tag for locally build images to pihole:local #1628

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Aug 25, 2024

Description

Set default tag for locally build images to pihole:local

Motivation and Context

To better distinguish between upstream und locally build images

How Has This Been Tested?

Yes.

chris@T14Gen5:~/Software/Pi-hole repositories/docker-pi-hole$ ./build.sh
Executing command: docker buildx build src/. --tag pihole:local --load --no-cache
[+] Building 14.5s (19/19) FINISHED                                                                                                       docker:default
 => [internal] load build definition from Dockerfile                                                                                                0.0s
 => => transferring dockerfile: 3.93kB                                                                                                              0.0s
 => resolve image config for docker-image://docker.io/docker/dockerfile:1                                                                           1.3s
 => CACHED docker-image://docker.io/docker/dockerfile:1@sha256:fe40cf4e92cd0c467be2cfc30657a680ae2398318afd50b0c80585784c604f28                     0.0s
 => [internal] load metadata for docker.io/library/alpine:3.20                                                                                      0.9s
 => [internal] load .dockerignore                                                                                                                   0.0s
 => => transferring context: 82B                                                                                                                    0.0s
 => [internal] load build context                                                                                                                   0.0s
 => => transferring context: 10.80kB                                                                                                                0.0s
 => CACHED [base 1/9] FROM docker.io/library/alpine:3.20@sha256:0a4eaa0eecf5f8c050e5bba433f58c052be7587ee8af3e8b3910ef9ab5fbe9f5                    0.0s
 => [base 3/9] ADD https://ftl.pi-hole.net/macvendor.db /macvendor.db                                                                               0.9s
 => [base 5/9] ADD --chmod=0755 https://raw.githubusercontent.com/pi-hole/PADD/PADD_FTLv6/padd.sh /usr/local/bin/padd                               0.3s
 => [base 2/9] RUN apk add --no-cache     bash     bind-tools     binutils     coreutils     curl     git     grep     iproute2-ss     jq     libc  5.9s
 => [base 3/9] ADD https://ftl.pi-hole.net/macvendor.db /macvendor.db                                                                               0.0s
 => [base 4/9] COPY crontab.txt /crontab.txt                                                                                                        0.0s
 => [base 5/9] ADD --chmod=0755 https://raw.githubusercontent.com/pi-hole/PADD/PADD_FTLv6/padd.sh /usr/local/bin/padd                               0.0s
 => [base 6/9] RUN git clone --depth 1 --single-branch --branch development-v6 https://github.com/pi-hole/web.git /var/www/html/admin &&     git c  1.8s
 => [base 7/9] RUN cd /etc/.pihole &&     install -Dm755 -d /opt/pihole &&     install -Dm755 -t /opt/pihole gravity.sh &&     install -Dm755 -t /  0.2s
 => [base 8/9] COPY --chmod=0755 bash_functions.sh /usr/bin/bash_functions.sh                                                                       0.0s
 => [base 9/9] COPY --chmod=0755 start.sh /usr/bin/start.sh                                                                                         0.0s
 => [remote-ftl-install 1/1] RUN if   [ "linux/amd64" = "linux/amd64" ];    then FTLARCH=amd64;     elif [ "linux/amd64" = "linux/386" ];      the  3.8s
 => exporting to image                                                                                                                              0.2s
 => => exporting layers                                                                                                                             0.2s
 => => writing image sha256:edf6eb7d2db4d01a42eb1f8b524967f1d5db465bf47540446e4705d4e791d957                                                        0.0s
 => => naming to docker.io/library/pihole:local                                                                                                     0.0s
chris@T14Gen5:~/Software/Pi-hole repositories/docker-pi-hole$ docker images
REPOSITORY                                                                                      TAG               IMAGE ID       CREATED         SIZE
pihole                                                                                          local             edf6eb7d2db4   5 seconds ago   89.7MB

@PromoFaux PromoFaux enabled auto-merge August 25, 2024 12:45
PromoFaux added a commit to pi-hole/docs that referenced this pull request Aug 25, 2024
PromoFaux added a commit to pi-hole/docs that referenced this pull request Aug 25, 2024
@PromoFaux PromoFaux merged commit bcc6393 into development-v6 Aug 25, 2024
7 checks passed
@PromoFaux PromoFaux deleted the default_tag branch August 25, 2024 12:51
PromoFaux added a commit to pi-hole/docs that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants