-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up a few things in the readme and code. #1551
Conversation
Check that pihole-FTL is configured with upstream servers or it will not function! Signed-off-by: Adam Warner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test need adjustment.
CMD_SETUP_WEB_PASSWORD = ". bash_functions.sh ; setup_web_password" |
Ah yes, maybe I will move back to its own function for easier testing. |
This link in the Pi-hole features section is broken. It is pointing to an old section:
Also, we should use a link to the repo main page (example: |
Signed-off-by: Adam Warner <[email protected]>
60072ca
to
24006c7
Compare
What does this PR aim to accomplish?:
Dipping my toes back into the water.
ensure_basic_configuration
dns.upstreams
config is set (either in environment or config file) hard exit if not.By submitting this pull request, I confirm the following:
git rebase
)