Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow end user to add additional packages to the image #1423

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

PromoFaux
Copy link
Member

@PromoFaux PromoFaux commented Sep 3, 2023

What does this PR aim to accomplish?:

Heavily inspired by Netdata's container. (Thanks @dschaper for the pointer)

Some people like nano, some people like vim. Why force them to use the better of the two? ;)

Also, anyone can apk add inside the container - this just makes it easier for those of us that always like to have whatever additional tools we need inside the container for debugging


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from a team September 3, 2023 12:24
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation required.

…ITIONAL_PACKAGES", to allow user to add any package they wish to the container. Will be mentioned in README with a HERE BE DRAGONS warning.

Signed-off-by: Adam Warner <[email protected]>
Signed-off-by: Adam Warner <[email protected]>
@PromoFaux PromoFaux force-pushed the v6/additional_packages branch from 12c6fb4 to 3ca2aea Compare September 20, 2023 23:03
@PromoFaux PromoFaux requested review from yubiuser and a team September 20, 2023 23:03
README.md Outdated Show resolved Hide resolved
Signed-off-by: Adam Warner <[email protected]>
@PromoFaux PromoFaux requested a review from a team September 25, 2023 16:27
src/start.sh Outdated Show resolved Hide resolved
Co-authored-by: RD WebDesign <[email protected]>
Signed-off-by: Adam Warner <[email protected]>
@PromoFaux PromoFaux requested a review from a team September 25, 2023 19:00
@PromoFaux PromoFaux merged commit 92ab9ad into development-v6 Sep 25, 2023
8 checks passed
@PromoFaux PromoFaux deleted the v6/additional_packages branch September 25, 2023 21:36
@rdwebdesign rdwebdesign added the v6 label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants