Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PHP_ENV_CONFIG and setup_web_php_env() #1269

Merged
merged 2 commits into from
Jan 15, 2023
Merged

Change PHP_ENV_CONFIG and setup_web_php_env() #1269

merged 2 commits into from
Jan 15, 2023

Conversation

rdwebdesign
Copy link
Member

Description

PR pi-hole/pi-hole#5103 changes the file used to config lighttpd.

This PR changes:

  • the PHP_ENV_CONFIG environment variable passed by the Dockerfile and
  • the setup_web_php_env() function to correctly find the .

Motivation and Context

#1268
PR pi-hole/pi-hole#5103 changes the file used to config lighttpd.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@rdwebdesign rdwebdesign marked this pull request as draft January 6, 2023 19:41
@rdwebdesign
Copy link
Member Author

Set to Draft until core changes are merged into master.

@rdwebdesign rdwebdesign marked this pull request as ready for review January 14, 2023 19:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PromoFaux PromoFaux merged commit 2c04346 into dev Jan 15, 2023
@PromoFaux PromoFaux deleted the fix/PHP_ENV_CONFIG branch January 15, 2023 20:55
@PromoFaux PromoFaux mentioned this pull request Jan 18, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdwebdesign @PromoFaux