Skip to content

Commit

Permalink
Merge pull request #1497 from pi-hole/alpine3_19
Browse files Browse the repository at this point in the history
Update alpine to 3.19
  • Loading branch information
yubiuser authored Dec 22, 2023
2 parents da2acb7 + 5f8ca18 commit a04a8ab
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 526 deletions.
4 changes: 2 additions & 2 deletions src/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG CONTAINER="3.18"
FROM alpine:${CONTAINER}
ARG alpine_version="3.19"
FROM alpine:${alpine_version}
# https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope

ARG TARGETPLATFORM
Expand Down
11 changes: 7 additions & 4 deletions test/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
FROM docker:24.0.4-cli-alpine3.18
ARG alpine_version="3.19"
ARG docker_version="24.0.7"

FROM docker:${docker_version}-cli-alpine${alpine_version}

COPY --chmod=0755 ./cmd.sh /usr/local/bin/cmd.sh
COPY --chmod=0755 ./entrypoint.sh /usr/local/bin/entrypoint.sh
COPY Pipfile* /root/
COPY requirements.txt /root/
WORKDIR /root

RUN apk add --no-cache \
python3-dev \
py3-pip \
curl \
&& pip3 install --no-cache-dir -U pip pipenv \
&& pipenv install --system \
&& pip3 install --break-system-packages --no-cache-dir -U pip \
&& pip3 install --break-system-packages --no-cache-dir -r requirements.txt \
# Not 100% sure what this line does, but it's always been in the Dockerfile (aside from pointing at a different file)
# Tests fall over without it. Investigate later.
&& sed -i 's|/bin/sh|/bin/bash|g' /usr/lib/python3.11/site-packages/testinfra/backend/docker.py
Expand Down
15 changes: 0 additions & 15 deletions test/Pipfile

This file was deleted.

Loading

0 comments on commit a04a8ab

Please sign in to comment.