Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export LOCALE #335

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Export LOCALE #335

merged 1 commit into from
Jan 17, 2023

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Exports the set LOCALE so subshells can inherit this setting. Otherwise, subshells will fall back to the system's default LOCALE which can break PADD in a few places if users language uses different separators for numbers.

Fixes #334 (comment)


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <[email protected]>
@yubiuser yubiuser requested a review from a team January 17, 2023 22:13
@yubiuser yubiuser linked an issue Jan 17, 2023 that may be closed by this pull request
@yubiuser yubiuser mentioned this pull request Jan 17, 2023
@yubiuser yubiuser merged commit 45541ab into development Jan 17, 2023
@yubiuser yubiuser deleted the export_locale branch January 17, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

printf-error: not completely converted
2 participants