Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make <domain> optional in dns.revServer #2116

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 11, 2024

What does this implement/fix?

Fixes #2115 by making <domain> optional for dns.revServer.

Before:

<enabled>,<ip-address>[/<prefix-len>],<server>[#<port>],<domain>

Now:

<enabled>,<ip-address>[/<prefix-len>],<server>[#<port>][,<domain>]

I labeled this Bugfix as it fixes an inconsistency between web (which is describing <domain> as being optional) and FTL (which insists on it before this PR).


Related issue or feature (if applicable): #2115

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

yubiuser
yubiuser previously approved these changes Nov 11, 2024
@DL6ER DL6ER merged commit 8b7a843 into development Nov 11, 2024
19 checks passed
@DL6ER DL6ER deleted the fix/validate_revServer branch November 11, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants