Code

Improve DHCP handling#1731

Code

Merged

DL6ER merged 7 commits intodevelopment-v6pi-hole/FTL:development-v6from fix/dhcp-rangepi-hole/FTL:fix/dhcp-rangeCopy head branch name to clipboardNov 16, 2023

+268-41

Commits

Commits on Nov 4, 2023

• Only add dhcp.leaseTime if it actually set. If not given, the default lease time is one hour for IPv4 and one day for IPv6 (dnsmasq defaults, see their man page).

  Show description for 39f350a
  DL6ER

  committed
  39f350a

  Copy full SHA for 39f350a

• Add dhcp.netmask (type IPv4 address) and change the type of dhcp.{start,end,router} from string to IPv4 address to allow detection of invalid settings (e.g., "192.168.1.3000") early on

  Show description for 6f2c6fe
  DL6ER

  committed
  6f2c6fe

  Copy full SHA for 6f2c6fe

• Add string format verification in API checker

  Show description for 75cd372
  DL6ER

  committed
  75cd372

  Copy full SHA for 75cd372

• Reject invalid config items (error 400) instead of merely logging a warning to the log

  Show description for b967799
  DL6ER

  committed
  b967799

  Copy full SHA for b967799

Commits on Nov 15, 2023

• Add additional DHCP range tests

  Show description for a356cbd
  DL6ER

  committed
  a356cbd

  Copy full SHA for a356cbd

• Use package ipaddress for IP address validation in API tests

  Show description for a691305
  DL6ER

  committed
  a691305

  Copy full SHA for a691305

Commits on Nov 16, 2023

• IPv4 address 0.0.0.0 and IPv6 address :: correspond to empty strings in FTL settings

  Show description for 503c053
  DL6ER

  committed
  503c053

  Copy full SHA for 503c053