Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embedded LUA to 5.4.4 #1495

Merged
merged 5 commits into from
Nov 26, 2022
Merged

Update embedded LUA to 5.4.4 #1495

merged 5 commits into from
Nov 26, 2022

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 25, 2022

What does this implement/fix?

Update embedded LUA library to its latest version and add the corresponding patches needed during upgrades.

$ pihole-FTL -vv

[...]

******************************** LUA ********************************
Lua 5.4.4  Copyright (C) 1994-2022 Lua.org, PUC-Rio

[...]

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER added the lua Lua script related changes label Nov 25, 2022
@DL6ER DL6ER requested a review from a team November 25, 2022 18:19
@yubiuser
Copy link
Member

Why did you remove the

/************** Pi-hole modification ***************/

lines?

I think it's quite nice to see them in the source.

@DL6ER DL6ER marked this pull request as draft November 25, 2022 18:51
@DL6ER DL6ER removed the request for review from a team November 25, 2022 18:52
@DL6ER
Copy link
Member Author

DL6ER commented Nov 25, 2022

We don't have them in the SQLite3 code, either and it's absolutely clear what is changed when simply looking at the patch file(s).

@DL6ER DL6ER marked this pull request as ready for review November 25, 2022 18:57
@DL6ER DL6ER requested a review from a team November 25, 2022 18:57
@DL6ER DL6ER merged commit af571b3 into development Nov 26, 2022
@DL6ER DL6ER deleted the update/lua branch November 26, 2022 17:30
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-20-and-web-v5-18-released/59959/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lua Lua script related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants