Keep Query Log details across FTL restart

[DL6ER]

By submitting this pull request, I confirm the following:

• I have read and understood the contributors guide.
• I have checked that another pull request for this purpose does not exist.
• I have considered, and confirmed that this submission will be valuable to others.
• I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10

---

When restarting FTL, it imports history from the database to repopulate the history. So far, this was only possible with a reduced set of variables to keep the database from growing forever. Recent database optimizations #1255 reduced the database size significantly allowing us to store more data in the database.

This PR adds storing all the details necessary for the query log so a restart goes (almost) invisible and without any data loss.

*) almost because some queries may not have been completed due to the forced restart and according service interruption.

[yubiuser]

I tried it but it did not really work for me. I got a lot of

[2022-01-31 20:07:14.640 24751M] DB warn: REPLY value 52 is invalid, 1643656012
[2022-01-31 20:07:14.640 24751M] DB warn: REPLY value 116 is invalid, 1643656013
[2022-01-31 20:07:14.640 24751M] DB warn: REPLY value 116 is invalid, 1643656013
[2022-01-31 20:07:14.640 24751M] DB warn: REPLY value 52 is invalid, 1643656017

But there is no reply_type with 52 or 116 in the database.

I also queried a test domain which was successfully stored in the database with all information, including reply_typ=4. After a restart, the query log displays Reply N/A

[DL6ER]

Thanks for your review, not sure how I missed this. We also have to set the response_time_calculated property to true or the reply will not be shown on the dashboard. The API still presented the data but the Javascript skipped it as it thought: When we don't have a response time, we cannot have a reply type either (as there is not response so far). Should be fixed.

[yubiuser]

Thanks for the update.

There are no REPLY value 52 is invalid warnings any more. Also the reply time and reply type dashboard issue is fixed.

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/a-graph-visualizing-response-times-of-forwarded-queries/53320/1

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529/1

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/resolve-client-ip-adresses-for-the-long-term-data-section/55655/2

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/add-hostname-of-clients-to-long-term-query-database/50103/11

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/can-we-have-an-option-to-keep-old-queries-when-we-do-restartdns/37304/8