-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print FTL version when calling the built in sqlite function only in interactive mode #1226
Conversation
The only thing I'm not sure of is the big header in
Because this is not true anymore, I added a dependency. |
Yes, this is a bad thing. It basically means the entire SQLite3 library needs to be recompiled entry time. This pushes incremental builds from seconds to minutes. Since we have a lot of those during regular development, this is definitely a no-go. Furthermore, editing |
0337691
to
0bc77ad
Compare
…nteractive mode Signed-off-by: Christian König <[email protected]>
1979ca6
to
3cf635e
Compare
Signed-off-by: Christian König <[email protected]>
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1 |
How familiar are you with the codebase?: {replace this text with a number from 1 to 10, with 1 being not familiar, and 10 being very familiar}
5
So far Pi-hole printed it's version string when calling the built-in SQLite engine also when not in interactive mode. This PR moves the printing function into sqlite's
shell.c
and prints right befor SQLite prints it's own version string.Before:
After: