Tweak test suite to also run on Fedora #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DL6ER
requested changes
Oct 18, 2021
pemensik
force-pushed
the
fedora-tests
branch
from
8221ee8 to
4f63793
Compare
pdns-recursor config path is different from both Debian and Alpine. Detect also Fedora specific path. Signed-off-by: Petr Menšík <[email protected]>
BIND 9.16.21 displays SVCB in text form. Compare always unknown style, even if that record is known. Signed-off-by: Petr Menšík <[email protected]>
pemensik
force-pushed
the
fedora-tests
branch
from
4f63793 to
2c1af03
Compare
|
Please also update the workflow file to use |
pemensik
added a commit
to pemensik/FTL
that referenced
this pull request
Oct 20, 2021
Required for MR pi-hole#1223 pass. Signed-off-by: Petr Menšík <[email protected]>
Required for MR pi-hole#1223 pass. Signed-off-by: Petr Menšík <[email protected]>
Checkout latest version of bats only if BATS is not set already. Allow using custom path, system bats instance for example. Signed-off-by: Petr Menšík <[email protected]>
pemensik
force-pushed
the
fedora-tests
branch
from
dea5f89 to
5715fe5
Compare
DL6ER
reviewed
Oct 20, 2021
DL6ER
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:
Please submit all pull requests against the
developmentbranch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?: 5
Pass tests even on Fedora 34, which has some paths different. Use system bats if available.
This template was created based on the work of
udemy-dl.