Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append no_fqdn_available when no local suffix has been defined #1209

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 8, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


See title. The behavior we are improving here has not been released to master, so far.
This PR, together with pi-hole/docs#578, fixes #1205.

@DL6ER DL6ER requested a review from a team October 8, 2021 07:17
@DL6ER DL6ER linked an issue Oct 8, 2021 that may be closed by this pull request
@DL6ER
Copy link
Member Author

DL6ER commented Oct 8, 2021

It's again the GHA tests that are failing. @PromoFaux Looking at, e.g., https://github.com/pi-hole/FTL/pull/1209/checks?check_run_id=3835806890

Expected:

# dns_queries_today 80

Found:

# dns_queries_today 72

Looking at what we have here, we see a lot of replies are not answered by 8.8.8.8#53. This is strange as Google's DNS turned out to be, by far (!), the most reliable DNS server out there. Either the GHA have a very bad connection to them (I don't believe this) or other jobs running on the same IP block may be able to trigger rate-limiting on their servers?

@DL6ER DL6ER merged commit cb5f6b5 into development Oct 9, 2021
@DL6ER DL6ER deleted the tweak/no_fqdn_available branch October 9, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIHOLE_PTR=hostnamefqdn answers with wrong hostname
2 participants