-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vw_adlist
(tests)
#1208
Update vw_adlist
(tests)
#1208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--
The CircleCI tests failed because of the non-existing parent tag I also restarted the GHA tests. DNS tests fail here a lot more often than on CircleCI. Restarted them as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with merging this despite the failing GHA tests (the Circle tests pass fine), however, see my comment about dropping vs. changing vw_adlist
on the core PR.
798d51e
to
5808121
Compare
I adjusted the test to fit https://github.com/pi-hole/pi-hole/pull/4379/files |
I will try to get this (and the accompanying core PR) tested tomorrow. Depends on how much time I'll have after reworking the tests so that they stop having issues on GHA (maybe GHA servers are not meant to connect to the internet or, at least, not often) |
#1212 is up to fix the tests on GHA |
If you could rebase on (or merge) |
5808121
to
456dbd6
Compare
one more rebase on |
0df7309
to
e35576c
Compare
Signed-off-by: yubiuser <[email protected]>
e35576c
to
65c9fc0
Compare
How familiar are you with the codebase?: {replace this text with a number from 1 to 10, with 1 being not familiar, and 10 being very familiar}
5
pi-hole/pi-hole#4372 removedvw_adlist
from thegravity.db
. There is no need anymore to test in this repo if the view does not exist anymore.Changes the test for
vw_adlist
to fit https://github.com/pi-hole/pi-hole/pull/4379/files