Improve interface detection #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
This was
linked to
issues
Oct 4, 2021
yubiuser
reviewed
Oct 5, 2021
yubiuser
approved these changes
Oct 6, 2021
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-11-web-v5-8-and-core-v5-6-released/50566/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
Fixes #1191 by extending interface analysis to also support configurations defining
bind-interface. So far, we have only seen users having this config line enabled unintentionally (auxiliaryubuntu-fanorlxdconfig files placed by the system into/etc/dnsmasq.d), however, this does not mean we should not support it. A second goal of the PR is to largely extend theDEBUG_NETWORKINGtoolset to ease debugging in complex network environments.The bug fix as been confirmed working.