Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements based on static-analysis of source code #1172

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Sep 23, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


This PR fixes several one-time memory leaks that might appear in failure cases of the database or memory allocation issues in several other places. None of them should be severe, however, we should obviously not leak memory in the first place. Furthermore, we check for the return value of a lot of routines that should not (but could) fail and enforce upper bounds for some DHCP options (relevant for dhcp-discover).

@DL6ER DL6ER merged commit 4cbf269 into development Sep 24, 2021
@DL6ER DL6ER deleted the tweak/static-code-analysis branch September 24, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants