Fix virtual interface address determination #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…finding their bound addresses Signed-off-by: DL6ER <[email protected]>
…ived a query on doesn't have the requested address type (e.g. virtual interfaces only configured with one IPv6 but no IPv6 address) Signed-off-by: DL6ER <[email protected]>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/finding-pi-hole-ip-addresses-after-v5-4-update/49712/11 |
dschaper
approved these changes
Sep 23, 2021
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/finding-pi-hole-ip-addresses-after-v5-4-update/49712/27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
This PR ensures we're recognizing virtual interfaces (e.g.,
eth0:0) as distinct interfaces even when the kernel does not treat the as interfaces with their own interface index. This is necessary to pick the correct local address when determining which address is the right one for replying toAandAAAAqueries topi.holeand<hostname>.In addition, we fix a small glitch if the interface we received a query on doesn't have the requested address type (e.g. virtual interfaces only configured with one IPv6 but no IPv6 address). Instead of replying with
0.0.0.0resp.::, we reply withNODATAwhich seems more menaingful.