Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for "pi.hole.<local_domain>" and "<hostname>.<local_domain>" #1169

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Sep 18, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


#1111 has added special handling for pi.hole and <hostname>. However, we forgot about the case when Pi-hole is the DHCP server and we know the local domain. In this case, we should use the automated reply forming - to serve the most appropriate IP address - also for pi.hole.<local_domain> and <hostname>.<local_domain>.

This PR adds these two new rules and hereby fixes #1168.

@DL6ER DL6ER added the Bugfix label Sep 18, 2021
@DL6ER DL6ER requested review from PromoFaux and dschaper September 18, 2021 06:23
@DL6ER DL6ER merged commit 703a05b into development Sep 18, 2021
@DL6ER DL6ER deleted the tweak/domain_suffix branch September 18, 2021 11:53
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/issue-with-http-pi-hole-admin-working-but-not-using-the-server-name-horndns-home-instead-of-pi-hole/49847/2

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pihole-not-resolving-its-own-hostname/50058/7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants