Add handling for "pi.hole.<local_domain>" and "<hostname>.<local_domain>" #1169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
#1111 has added special handling for
pi.hole
and<hostname>
. However, we forgot about the case when Pi-hole is the DHCP server and we know the local domain. In this case, we should use the automated reply forming - to serve the most appropriate IP address - also forpi.hole.<local_domain>
and<hostname>.<local_domain>
.This PR adds these two new rules and hereby fixes #1168.