Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve locking during heavy TCP forking #1134

Merged
merged 6 commits into from
May 22, 2021
Merged

Improve locking during heavy TCP forking #1134

merged 6 commits into from
May 22, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented May 11, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10

Lock when terminating forks to ensure we remap shared memory if heavy TCP activity causes shared memory objects to resize often.

@DL6ER DL6ER added the Bugfix label May 11, 2021
@DL6ER DL6ER requested a review from a team May 11, 2021 09:05
@DL6ER DL6ER added the PR: Approval Required Open Pull Request, needs approval label May 19, 2021
@DL6ER DL6ER marked this pull request as ready for review May 19, 2021 21:52
@DL6ER DL6ER linked an issue May 19, 2021 that may be closed by this pull request
FTL crashed latest master branch (newer than my last post, different Pihole) #1124
Closed
@DL6ER DL6ER force-pushed the fix/lock_gravityClose branch from d5a33a4 to e663677 Compare May 22, 2021 09:07
@DL6ER DL6ER requested review from dschaper and PromoFaux May 22, 2021 11:27
@DL6ER
Copy link
Member Author

DL6ER commented May 22, 2021

Bugfix confirmed by original reporter in #1124 (comment)

@DL6ER DL6ER merged commit 77b578e into development May 22, 2021
@DL6ER DL6ER deleted the fix/lock_gravityClose branch May 22, 2021 20:26
@DL6ER DL6ER added PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels May 22, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/49544/1

@renovate renovate bot mentioned this pull request Sep 30, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Oct 17, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jan 3, 2022
Closed
1 task
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pihole-crashed-segmentation-fault-resizing-queries-in-dev-shm/52603/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PromoFaux PromoFaux PromoFaux approved these changes

@dschaper dschaper Awaiting requested review from dschaper

Assignees
No one assigned
Labels
Bugfix PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FTL crashed latest master branch (newer than my last post, different Pihole)
3 participants
@DL6ER @pralor-bot @PromoFaux