Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ouroboros to 0.17 #54

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Bump ouroboros to 0.17 #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3a95f1
Bump ouroboros to 0.17
andreaphylum Jun 21, 2023
2c36ef0
Adjust comment formatting
andreaphylum Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vuln-reach/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ edition = "2021"
flate2 = "1.0.24"
itertools = "0.10.5"
lazy_static = "1.4.0"
ouroboros = "0.15.5"
ouroboros = "0.17.0"
serde = { version = "1.0.152", features = ["derive"] }
serde_json = "1.0.93"
tar = "0.4.38"
Expand Down
14 changes: 9 additions & 5 deletions vuln-reach/src/javascript/lang/exports.rs
View file
Open in desktop
andreaphylum marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,19 @@ use crate::{Error, Tree, JS};
//
// All the compatible export statements in CommonJS are the following:
// 1. module.exports = an object, an identifier, or a function
//
// When this is found, override all previous exports.
//
// 2. module.exports.foo = anything
//
// When this is found, override exports of the same name only.
//
// 3. exports.foo = anything
// This is compatible with 2., but if there is even one instance
// of 1., this definition does nothing. This is because the
// module-global `exports` is a shorthand for `module.exports`,
// but if something is assigned to `module.exports`, this simply
// gets cloaked and the reference gets lost.
//
// This is compatible with 2., but if there is even one instance of 1., this
// definition does nothing. This is because the module-global `exports` is a
// shorthand for `module.exports`, but if something is assigned to
// `module.exports`, this simply gets cloaked and the reference gets lost.
//
// For the time, we only care about top-level exported objects,
// i.e.:
Expand Down