Bump uuid from 0.8.0 -> 1.0.0 #27
Conversation
This patch bumps the version of the uuid crate to 1.0.0. This is a breaking change because uuid is used in the public interface of this crate.
|
I just noticed this, but is there a reason why |
Just because nobody has set it up yet, I believe. |
|
I've opened #28 just in case I don't get to it today so it doesn't get lost over the weekend. |
|
The It looks like other dependencies for |
|
I tried to compile api with this change. Rocket and sqlx are bringing in the old uuid and there are conflicts at least for sqlx. Relevant sqlx PR: launchbadge/sqlx#1821 |
|
This needs to hold off till we can update API for now. |
It turns out that we don't actually need this as a direct dependency because `phylum_types` has type aliases for all of this. Doing it this way has pros and cons. Maybe someday we'll decide that the aliases in `phylum_types` don't actually make sense or that they should actually use the newtype pattern. But for now, they exist, so we might as well use them. As an nice bonus, this means we won't have to worry about coordinating our version bump of the uuid crate with phylum-dev/phylum-types#27. Once that is merged, we will automatically be upgrade (after the next cargo update)
It turns out that we don't actually need this as a direct dependency because `phylum_types` has type aliases for all of this. Doing it this way has pros and cons. Maybe someday we'll decide that the aliases in `phylum_types` don't actually make sense or that they should actually use the newtype pattern. But for now, they exist, so we might as well use them. As an nice bonus, this means we won't have to worry about coordinating our version bump of the uuid crate with phylum-dev/phylum-types#27. Once that is merged, we will automatically be upgrade (after the next cargo update)
It turns out that we don't actually need this as a direct dependency because `phylum_types` has type aliases for all of this. Doing it this way has pros and cons. Maybe someday we'll decide that the aliases in `phylum_types` don't actually make sense or that they should actually use the newtype pattern. But for now, they exist, so we might as well use them. As an nice bonus, this means we won't have to worry about coordinating our version bump of the uuid crate with phylum-dev/phylum-types#27. Once that is merged, we will automatically be upgrade (after the next cargo update)
This patch bumps the version of the uuid crate to 1.0.0. This is a
breaking change because uuid is used in the public interface of this
crate.
Ref: phylum-dev/cli#326