-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aviary org docs #225
base: main
Are you sure you want to change the base?
Add Aviary org docs #225
Conversation
PyPI does work with properly supplied URL and NPM is confirmed fixed with https://github.com/phylum-dev/aviary/pull/77. So I think this should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an observation. I'm not current with the part of the codebase responsible for that, but I wonder if a different separator could be used for org/group
? I think having to include an explicit %2f
might look confusing to some. All in all I don't think it's a big deal though.
It must be url-encoded where I've done so. In the places where it isn't it would technically also be possible to url-encode it since we had to support decoding in Aviary for NPM, but I've left it as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably hold on merging this until I start transitioning people over to orgs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was tested by checking it out locally and building/viewing the pages.
Our documentation styles and sensibilities are at odds once again when it comes to verbosity 😜...but not enough to hold up this review.
Holding this PR until @furi0us333 decides it's good to go. From a technical perspective it should be complete. |
NPM and PyPI do not seem to actually work yet. It seems like we need to explicitly support
%2F
as a separator in Aviary.