Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# *.packages.config support #1545

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add C# *.packages.config support #1545

wants to merge 3 commits into from

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Nov 27, 2024

This adds support for packages.config files for the C# ecosystem under the new NugetConfig lockfile name.

The file format itself seems to be relatively simple, with just a list of package names and optional versions. The current test fixture is based on examples of this lockfile found on https://github.com.

Both packages.config on its own and *.packages.config are supported as valid names. Since this seems to be a lockfile there is no need for lockfile generation.

This adds support for `packages.config` files for the C# ecosystem under
the new `NugetConfig` lockfile name.

The file format itself seems to be relatively simple, with just a list
of package names and optional versions. The current test fixture is
based on examples of this lockfile found on <https://github.com>.

Both `packages.config` on its own and `*.packages.config` are supported
as valid names. Since this seems to be a lockfile there is no need for
lockfile generation.
@cd-work cd-work requested a review from a team as a code owner November 27, 2024 23:16
@cd-work cd-work self-assigned this Nov 27, 2024
@maxrake maxrake self-requested a review November 27, 2024 23:31
@maxrake
Copy link
Contributor

maxrake commented Nov 27, 2024

Can the files be named as *packages.config as well? Or, will there always be a . first (*.packages.config)? I plan to look at this PR in more detail next week, but keeping someone else on the reviewer list who knows C# better is recommended.

@cd-work
Copy link
Contributor Author

cd-work commented Nov 27, 2024

Can the files be named as packages.config as well? Or, will there always be a . first (.packages.config)?

https://github.com/search?q=path%3A**%2F*packages.config+language%3AXML&type=code suggests to me that only packages.config and *.packages.config are valid. This makes sense to me because it matches the new lockfile version and it's just generally sensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants