Add support for bun-generated yarn lockfiles #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bun JavaScript package manager has the option to generate yarn lockfiles, however lockfiles generated by bun contain an additional header line which caused our existing parser to fail. To allow our parser to support bun's yarn lockfile format, we now ignore all lines starting with `#`. This also fixes an issue with parsing malformed yarn lockfiles, where all parsing failures were accepted as long as the first specified package didn't fail parsing, due to the way `many1` works. Closes #1491.
cd-work
commented
Sep 10, 2024
maxrake
requested changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bun JavaScript package manager has the option to generate yarn lockfiles, however lockfiles generated by bun contain an additional header line which caused our existing parser to fail.
To allow our parser to support bun's yarn lockfile format, we now ignore all lines starting with
#.This also fixes an issue with parsing malformed yarn lockfiles, where all parsing failures were accepted as long as the first specified package didn't fail parsing, due to the way
many1works.Closes #1491.