-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'format not a string literal and no format arguments [-Werror=format-security]' #8
base: master
Are you sure you want to change the base?
Conversation
Would love to see it merged (would fix bug in our gem - EthWorks/ethereum.rb#11) |
I'd also like to see this merged, it affects the ruby-eth gem as well. |
plz merge |
please! Thank you! |
This gem is abandoned. |
an easy workaround would be
|
`digest-sha3` is a C-extension gem which fails to build on Nix because it uses non-literals as format strings which is forbidden by the default Nix hardening settings. There is a pull request to fix that ([1]), but the gem seems to be abandoned. This PR disables the "format" hardening for `digest-sha3`. [1]: phusion/digest-sha3-ruby#8
why not merging this? |
@mathieujobin I'm not sure why @FooBarWidget could you please take a look at this PR and provide feedback? |
Any update on this? This rolls into this new issue if the repo is going to be maintained: #13 |
Thank you for the fix. |
I published this as |
Thanks |
I'd like to add a simple fix. The problem is that at least in Ubuntu gcc has "-Wformat-security" as a default flag, and together with "-Werror=format-security" they lead to an error if fprintf is used without format string (https://wiki.ubuntu.com/ToolChain/CompilerFlags#A-Wformat_-Wformat-security). The issue is #7