Include add_before and add_after in new item functions #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'develop' into eli/auto-add # Conflicts: # R/case.R # R/code.R # R/req.R # man/new_item.Rd
thebioengineer
requested changes
Apr 8, 2021
|
there are tests failing now that were explicitly adding the files into the validation.yml! haha. at least we know if works!! |
|
Yep! I'm working on those now. Should be ready by end of today |
|
Hey @thebioengineer, I had some trouble with the tests. I think my VM must have a weird pdf render because I get a lot of errors on my machine. But they are passing here so it should be good to merge for now. |
thebioengineer
approved these changes
Apr 12, 2021
|
@elimillera did pulling branch |
mariev
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
add_file_to_configfunctionality and adds the parametersadd_beforeandadd_afterto be passed into thebeforeandafterparameters ofadd_file_to_config.I'm not sure what the plans are for merging things in but I can start working off this branch to add 'tidy_select' functionality if I'm on the right track.
Closes #66