Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add update_translations_on_source_match #670

Merged
merged 4 commits into from
Aug 26, 2024
Merged

feat: Add update_translations_on_source_match #670

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e91869
Add update_translations_on_source_match to cli
ildarsafin Aug 26, 2024
6bf9823
Fix test
ildarsafin Aug 26, 2024
5148057
Update paths/uploads/create.yaml
ildarsafin Aug 26, 2024
ad06824
Update doc
ildarsafin Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clients/java/src/test/java/com/phrase/client/api/UploadsApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ public void uploadCreateTest() throws ApiException, IOException, InterruptedExce
String tags = null;
Boolean updateTranslations = null;
Boolean updateTranslationKeys = true;
Boolean updateTranslationsOnSourceMatch = null;
Boolean updateDescriptions = null;
Boolean convertEmoji = null;
Boolean skipUploadTags = null;
Expand All @@ -107,7 +108,7 @@ public void uploadCreateTest() throws ApiException, IOException, InterruptedExce
Boolean autotranslate = null;
Boolean markReviewed = null;
Boolean tagOnlyAffectedKeys = null;
Upload response = api.uploadCreate(projectId, file, fileFormat, localeId, xPhraseAppOTP, branch, tags, updateTranslations, updateTranslationKeys, updateDescriptions, convertEmoji, skipUploadTags, skipUnverification, fileEncoding, localeMapping, formatOptions, autotranslate, markReviewed, tagOnlyAffectedKeys);
Upload response = api.uploadCreate(projectId, file, fileFormat, localeId, xPhraseAppOTP, branch, tags, updateTranslations, updateTranslationKeys, updateTranslationsOnSourceMatch, updateDescriptions, convertEmoji, skipUploadTags, skipUnverification, fileEncoding, localeMapping, formatOptions, autotranslate, markReviewed, tagOnlyAffectedKeys);

Assert.assertEquals("valid id returned", "id_example", response.getId());
Assert.assertEquals("valid creation date returned", OffsetDateTime.parse("2015-01-28T09:52:53Z"), response.getCreatedAt());
Expand Down
6 changes: 6 additions & 0 deletions doc/compiled.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14989,6 +14989,12 @@
"default": true,
"example": null
},
"update_translations_on_source_match": {
"description": "Pass `true` to update target translations only if the source translations match the uploaded multilingual file",
"type": "boolean",
"default": false,
"example": null
},
"update_descriptions": {
"description": "Existing key descriptions will be updated with the file content. Empty descriptions overwrite existing descriptions.",
"type": "boolean",
Expand Down
5 changes: 5 additions & 0 deletions paths/uploads/create.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ requestBody:
type: boolean
default: true
example:
update_translations_on_source_match:
description: Pass `true` to update target translations only if the source translations match the uploaded multilingual file
ildarsafin marked this conversation as resolved.
Show resolved Hide resolved
type: boolean
default: false
example:
update_descriptions:
description: Existing key descriptions will be updated with the file content. Empty descriptions overwrite existing descriptions.
type: boolean
Expand Down
Loading