Allow to get defined variables from scope that are maybe defined

[ruudk]

Feature request

Currently, Scope::getDefinedVariables() only returns certain variables.

How to retrieve variables that are maybe defined?

https://github.com/phpstan/phpstan-src/blob/f38addda2b151b6e41a746a37659c0bbe9e2293b/src/Analyser/MutatingScope.php#L557-L572

Did PHPStan help you today? Did it make you happy in any way?

No response

[ruudk]

Had to create this ugly thing to be able to retrieve them:

$builder = ConstantArrayTypeBuilder::createEmpty();
foreach ($variables as $variable) {
    $builder->setOffsetValueType(new ConstantStringType($variable), $scope->getVariableType($variable));
}

foreach ($scope->debug() as $key => $value) {
    if ( ! str_starts_with($key, '$')) {
        continue;
    }

    if ( ! str_ends_with($key, ' (Maybe)')) {
        continue;
    }

    $variable = substr($key, 1, -8);
    $builder->setOffsetValueType(new ConstantStringType($variable), $scope->getVariableType($variable), true);
}

return $builder->getArray();

[ondrejmirtes]

Oh, that's a creative hack 😂

I'd accept a PR that adds Scope::getMaybeDefinedVariables().

[ruudk]

Done in phpstan/phpstan-src#3521

[ondrejmirtes]

Implemented phpstan/phpstan-src#3521

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.