Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that stringNotEmpty is a string #2

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

mavimo
Copy link
Contributor

@mavimo mavimo commented Dec 12, 2018

Check that Assert::stringNotEmpty($var) indicate that is $var string

@mavimo mavimo mentioned this pull request Dec 12, 2018
@mavimo
Copy link
Contributor Author

mavimo commented Dec 12, 2018

This may need rebase once #5 is merged

The failure is fixed in #4

@mavimo mavimo force-pushed the include-stringNotEmpty-check branch from fed97aa to 1a5171b Compare December 12, 2018 22:04
@mavimo
Copy link
Contributor Author

mavimo commented Dec 21, 2018

@ondrejmirtes do you have time to check it or give me more indication on needed changes?

@ondrejmirtes ondrejmirtes merged commit 0af1c83 into phpstan:master Jan 2, 2019
@ondrejmirtes
Copy link
Member

Thanks!

@mavimo mavimo deleted the include-stringNotEmpty-check branch January 4, 2019 15:55
staabm added a commit to staabm/phpstan-webmozart-assert that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants