Skip to content

Commit

Permalink
[BCB] Remove legacy config options with _ in their name
Browse files Browse the repository at this point in the history
  • Loading branch information
ondrejmirtes committed Sep 30, 2024
1 parent 4f260f0 commit 7e5633f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 14 deletions.
6 changes: 0 additions & 6 deletions extension.neon
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,8 @@ parameters:
uncheckedExceptionClasses:
- 'Symfony\Component\Console\Exception\InvalidArgumentException'
symfony:
container_xml_path: null
containerXmlPath: null
constant_hassers: true
constantHassers: true
console_application_loader: null
consoleApplicationLoader: null
featureToggles:
skipCheckGenericClasses:
Expand Down Expand Up @@ -109,11 +106,8 @@ parameters:

parametersSchema:
symfony: structure([
container_xml_path: schema(string(), nullable())
containerXmlPath: schema(string(), nullable())
constant_hassers: bool()
constantHassers: bool()
console_application_loader: schema(string(), nullable())
consoleApplicationLoader: schema(string(), nullable())
])

Expand Down
6 changes: 3 additions & 3 deletions src/Symfony/Configuration.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,17 @@ public function __construct(array $parameters)

public function getContainerXmlPath(): ?string
{
return $this->parameters['containerXmlPath'] ?? $this->parameters['container_xml_path'] ?? null;
return $this->parameters['containerXmlPath'];
}

public function hasConstantHassers(): bool
{
return $this->parameters['constantHassers'] ?? $this->parameters['constant_hassers'] ?? true;
return $this->parameters['constantHassers'];
}

public function getConsoleApplicationLoader(): ?string
{
return $this->parameters['consoleApplicationLoader'] ?? $this->parameters['console_application_loader'] ?? null;
return $this->parameters['consoleApplicationLoader'];
}

}
3 changes: 0 additions & 3 deletions tests/Symfony/config.neon

This file was deleted.

4 changes: 2 additions & 2 deletions tests/Type/Symfony/extension-test.neon
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
parameters:
symfony:
console_application_loader: console_application_loader.php
container_xml_path: container.xml
consoleApplicationLoader: console_application_loader.php
containerXmlPath: container.xml

0 comments on commit 7e5633f

Please sign in to comment.