use is_file() over file_exists(), which is faster #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Oct 20, 2021
Comment on lines
-42
to
-44
| if (!file_exists($path)) { | ||
| throw new \PHPStan\File\PathNotFoundException($path); | ||
| } elseif (is_file($path)) { |
There was a problem hiding this comment.
this is the only spot where logic was changed within the PR.
I have moved the fast is_file positive-lookup case in the front and moved the less-likely file_exists negative case into the else-if
staabm
changed the title
|
I was not able to come up with a profile which shows a measurable improvement by this PR. only thing I can say is, that in case you wanne play safe, we can close here. its up to you. |
|
The only risk here is that |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file_exists() is up to 100 times slower
Inspired by https://bugs.php.net/bug.php?id=78285