Nullsafe operator false negative - RuleLevelHelper::findTypeToCheck - make null-safe shortcircuiting optional #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsavmic
force-pushed
the
mo-nullsafe-shortcircuiting-optional
branch
3 times, most recently
from
be93bda to
60ba530
Compare
olsavmic
force-pushed
the
mo-nullsafe-shortcircuiting-optional
branch
2 times, most recently
from
e90ba5c to
54733e7
Compare
ondrejmirtes
requested changes
Oct 5, 2021
|
@olsavmic If you replied to my comment, the message didn't go through. |
olsavmic
commented
Oct 6, 2021
|
@ondrejmirtes My bad, I forgot to submit the review comments :) |
olsavmic
force-pushed
the
mo-nullsafe-shortcircuiting-optional
branch
5 times, most recently
from
294425e to
10837ab
Compare
olsavmic
commented
Oct 7, 2021
ondrejmirtes
requested changes
Oct 8, 2021
olsavmic
force-pushed
the
mo-nullsafe-shortcircuiting-optional
branch
from
2f20de9 to
441a3cf
Compare
|
Thank you, I really like this solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves phpstan/phpstan#5687, phpstan/phpstan-strict-rules#135