Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support array as template type bound. #673

Merged
merged 4 commits into from
Sep 16, 2021
Merged

Support array as template type bound. #673

merged 4 commits into from
Sep 16, 2021

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Sep 16, 2021 •
edited
Loading

This PR:

ondrejmirtes
ondrejmirtes requested changes Sep 16, 2021
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid! Please do these two changes, mark it as ready and I'll merge it :)

tests/PHPStan/Analyser/data/generics.php Outdated Show resolved Hide resolved
tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php Outdated Show resolved Hide resolved
@drupol
Copy link
Contributor Author

drupol commented Sep 16, 2021

@ondrejmirtes If you want, we can wait a bit more and I'll submit the same kind of stuff for iterable, Generator and Iterator.

WDYT ?

@ondrejmirtes
Copy link
Member

@drupol I think all of those are already supported.

@ondrejmirtes ondrejmirtes marked this pull request as ready for review September 16, 2021 19:50
@ondrejmirtes ondrejmirtes merged commit 36649d3 into phpstan:master Sep 16, 2021
@ondrejmirtes
Copy link
Member

Thank you!

@drupol
Copy link
Contributor Author

drupol commented Sep 16, 2021

Excellent! Thanks for the support into making this :)

@ondrejmirtes ondrejmirtes mentioned this pull request Sep 16, 2021
Closed
@ZebulanStanphill
Copy link
Contributor

Thanks for this PR. I think this is going to help quite a bit in one of the projects I'm working on.

@drupol drupol deleted the feat/support-array-as-template-type-bound branch September 17, 2021 06:47
@drupol drupol mentioned this pull request Sep 17, 2021
Merged
5 tasks
@ZebulanStanphill ZebulanStanphill mentioned this pull request Oct 20, 2021
Closed
@mente mente mentioned this pull request Dec 29, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drupol @ondrejmirtes @ZebulanStanphill