Implement ArrayAccess->offsetExists narrowing
#3760
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Dec 29, 2024
Comment on lines
69
to
81
| foreach($scope->getType($node->var)->getObjectClassReflections() as $classReflection) { | ||
| $implementsTags = $classReflection->getImplementsTags(); | ||
|
|
||
| if ( | ||
| !isset($implementsTags[\ArrayAccess::class]) | ||
| || !$implementsTags[\ArrayAccess::class]->getType() instanceof GenericObjectType | ||
| ) { | ||
| continue; | ||
| } | ||
|
|
||
| $implementsType = $implementsTags[\ArrayAccess::class]->getType(); | ||
| $arrayAccessGenericTypes = $implementsType->getTypes(); | ||
| if (!isset($arrayAccessGenericTypes[1])) { | ||
| continue; | ||
| } | ||
|
|
||
| return $this->typeSpecifier->create( | ||
| $node->var, | ||
| new HasOffsetValueType($keyType, $arrayAccessGenericTypes[1]), | ||
| $context, | ||
| $scope, | ||
| ); | ||
| } |
There was a problem hiding this comment.
reading the "raw" array-access generic type, because ObjectType->getValueType will append null for possibly non-existant offsets. the added null makes it impossible for us to differentiate a nullable-typed generic from a non-nullable generic.
I guess this logic should be moved into the type-system to make it also work for isset() on ArrayAccess objects
staabm
force-pushed
the
access
branch
3 times, most recently
from
3c17859 to
4482676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#3323 as described in comment